ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 58921: Ranger-1552: Ranger usersync or ranger kms not able to communicate to ranger admin and no exception or error seen in the ranger user sync or kms logs.
Date Thu, 04 May 2017 21:00:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58921/#review173959
-----------------------------------------------------------




credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java
Lines 43 (patched)
<https://reviews.apache.org/r/58921/#comment247040>

    Will exiting like this affect previous behavior (e.g. ambari based installs)? Shouldn't
callers of this method be updated to handle that?
    
    Also could you please elaborate on the testing performed?


- Velmurugan Periasamy


On May 4, 2017, 6 p.m., Madhavi Amirneni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58921/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 6 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Madhan Neethiraj, and Sailaja Polavarapu.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The default communication between Ranger admin and Ranger usersync or Ranger kms is SSL
enabled. When there is an error during the hadoop keystore creation, there is no exception
thrown but there was a non-zeor return code returned. However, ranger did not check/handle
this error return code and continued, which has caused Ranger usersync to assume the communication
to be normal and continue.  
>  
> With this fix, when there is an error during the keystore creation, an error message
is logged and the process will exit.
> 
> 
> Diffs
> -----
> 
>   credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java a7e433f

> 
> 
> Diff: https://reviews.apache.org/r/58921/diff/2/
> 
> 
> Testing
> -------
> 
> Manual unit testing & Automated tests.
> 
> 
> Thanks,
> 
> Madhavi Amirneni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message