From dev-return-12347-apmail-ranger-dev-archive=ranger.apache.org@ranger.apache.org Tue May 2 03:35:05 2017 Return-Path: X-Original-To: apmail-ranger-dev-archive@www.apache.org Delivered-To: apmail-ranger-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 67826183EF for ; Tue, 2 May 2017 03:35:05 +0000 (UTC) Received: (qmail 15343 invoked by uid 500); 2 May 2017 03:35:05 -0000 Delivered-To: apmail-ranger-dev-archive@ranger.apache.org Received: (qmail 15294 invoked by uid 500); 2 May 2017 03:35:05 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 15283 invoked by uid 99); 2 May 2017 03:35:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 May 2017 03:35:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8E1B7C01DB; Tue, 2 May 2017 03:35:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.2 X-Spam-Level: *** X-Spam-Status: No, score=3.2 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 0SzFQVmH0WkZ; Tue, 2 May 2017 03:35:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 248225FC63; Tue, 2 May 2017 03:35:03 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B761FE01A8; Tue, 2 May 2017 03:35:02 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A337DC406FB; Tue, 2 May 2017 03:35:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0085820063134844114==" MIME-Version: 1.0 Subject: Re: Review Request 58871: RANGER-1550 : HDFS test connection and resource lookup failing From: Ankita Sinha To: Mehul Parikh , Gautam Borad , Abhay Kulkarni , Ramesh Mani , Velmurugan Periasamy , Sailaja Polavarapu , Selvamohan Neethiraj , Ankita Sinha , Madhan Neethiraj , Don Bosco Durai Cc: Pradeep Agrawal , ranger Date: Tue, 02 May 2017 03:35:02 -0000 Message-ID: <20170502033502.62744.50488@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ankita Sinha X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58871/ X-Sender: Ankita Sinha X-ReviewBoard-ShipIt: 1 References: <20170429073518.16780.8316@reviews-vm2.apache.org> In-Reply-To: <20170429073518.16780.8316@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Ankita Sinha X-ReviewRequest-Repository: ranger --===============0085820063134844114== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58871/#review173554 ----------------------------------------------------------- Ship it! Ship It! - Ankita Sinha On April 29, 2017, 7:35 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58871/ > ----------------------------------------------------------- > > (Updated April 29, 2017, 7:35 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1550 > https://issues.apache.org/jira/browse/RANGER-1550 > > > Repository: ranger > > > Description > ------- > > **Problem Statement :** Test connection is failing with below message on UI. > Connection Failed. > Unable to retrieve any files using given parameters, You can still save the repository and start creating policies, but you would not be able to use autocomplete for resource names. Check ranger_admin.log for more info. > java.lang.NullPointerException. > > ** Proposed Solution:** HIVE_SITE_FILE_PATH property is set to null at line 152 of HadoopConfigHolder.java. we need to set it blank or have null check before reading the file everywhere otherwise while reading the file directly may cause nullpointer exception. I have set the properties value to blank for now. > Note : Implementation can be changed if the proposed approach is not good and there is a better way to solve this issue. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 928398d > > > Diff: https://reviews.apache.org/r/58871/diff/1/ > > > Testing > ------- > > Checked test Connection of HDFS, HIVE and Hbase service. > > > Thanks, > > Pradeep Agrawal > > --===============0085820063134844114==--