From dev-return-12377-apmail-ranger-dev-archive=ranger.apache.org@ranger.apache.org Wed May 3 09:20:43 2017 Return-Path: X-Original-To: apmail-ranger-dev-archive@www.apache.org Delivered-To: apmail-ranger-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D73D18FB9 for ; Wed, 3 May 2017 09:20:43 +0000 (UTC) Received: (qmail 30672 invoked by uid 500); 3 May 2017 09:20:43 -0000 Delivered-To: apmail-ranger-dev-archive@ranger.apache.org Received: (qmail 30621 invoked by uid 500); 3 May 2017 09:20:43 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 30610 invoked by uid 99); 3 May 2017 09:20:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 May 2017 09:20:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 45F751910EA; Wed, 3 May 2017 09:20:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.201 X-Spam-Level: *** X-Spam-Status: No, score=3.201 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id KlQ819msQp-d; Wed, 3 May 2017 09:20:40 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3BAF35FB48; Wed, 3 May 2017 09:20:40 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D94FEE01A8; Wed, 3 May 2017 09:20:39 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id AA70EC4004B; Wed, 3 May 2017 09:20:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7831731852879672348==" MIME-Version: 1.0 Subject: Re: Review Request 58660: Log is very important for big data platform. The main purpose of log analysis is that we need to know who is running the service, in which machine running service, which service out of the problem. The ranger security admin should support the feature. From: pengjianhua To: Gautam Borad , Alok Lal , Ramesh Mani , Velmurugan Periasamy , Colm O hEigeartaigh , Selvamohan Neethiraj , Ankita Sinha , Madhan Neethiraj , Qiang Zhang , Don Bosco Durai Cc: pengjianhua , ranger Date: Wed, 03 May 2017 09:20:39 -0000 Message-ID: <20170503092039.39150.73349@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: pengjianhua X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58660/ X-Sender: pengjianhua References: <20170503013108.39150.83426@reviews-vm2.apache.org> In-Reply-To: <20170503013108.39150.83426@reviews-vm2.apache.org> Reply-To: pengjianhua X-ReviewRequest-Repository: ranger --===============7831731852879672348== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On 五月 3, 2017, 1:31 a.m., Qiang Zhang wrote: > > Hi Colm, how do you see for Bosco's review? > > Colm O hEigeartaigh wrote: > Yes I'm happy with what Bosco has said, so please go ahead and update the patch along those lines. Ok. I will update the patch. - pengjianhua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58660/#review173684 ----------------------------------------------------------- On 四月 24, 2017, 9:01 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58660/ > ----------------------------------------------------------- > > (Updated 四月 24, 2017, 9:01 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1540 > https://issues.apache.org/jira/browse/RANGER-1540 > > > Repository: ranger > > > Description > ------- > > Log is very important for big data platform. The main purpose of log analysis is that we need to know who is running the service, in which machine running service, which service out of the problem. The ranger security admin should support the feature. > Implement logic: > 1. Modify the value of log4j.appender.xa_log_appender.file from $ > {logdir}/ranger_admin.log to ${logdir} > > /ranger-$ > {user}rangeradmin${hostname}.log in /security-admin/src/main/webapp/WEB-INF/log4j.properties file. > 2. Pass ${user} > > and $ > {hostname} > > as parameters to org.apache.ranger.server.tomcat.EmbeddedServer. > 3. User obtains the user and hostname information by parsing the log file name. > > > Diffs > ----- > > embeddedwebserver/scripts/ranger-admin-services.sh f2d2bf5 > security-admin/src/main/webapp/WEB-INF/log4j.properties 211de86 > > > Diff: https://reviews.apache.org/r/58660/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > > --===============7831731852879672348==--