> On 五月 3, 2017, 1:31 a.m., Qiang Zhang wrote: > > Hi Colm, how do you see for Bosco's review? > > Colm O hEigeartaigh wrote: > Yes I'm happy with what Bosco has said, so please go ahead and update the patch along those lines. Ok. I will update the patch. - pengjianhua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58660/#review173684 ----------------------------------------------------------- On 四月 24, 2017, 9:01 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58660/ > ----------------------------------------------------------- > > (Updated 四月 24, 2017, 9:01 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1540 > https://issues.apache.org/jira/browse/RANGER-1540 > > > Repository: ranger > > > Description > ------- > > Log is very important for big data platform. The main purpose of log analysis is that we need to know who is running the service, in which machine running service, which service out of the problem. The ranger security admin should support the feature. > Implement logic: > 1. Modify the value of log4j.appender.xa_log_appender.file from $ > {logdir}/ranger_admin.log to ${logdir} > > /ranger-$ > {user}rangeradmin${hostname}.log in /security-admin/src/main/webapp/WEB-INF/log4j.properties file. > 2. Pass ${user} > > and $ > {hostname} > > as parameters to org.apache.ranger.server.tomcat.EmbeddedServer. > 3. User obtains the user and hostname information by parsing the log file name. > > > Diffs > ----- > > embeddedwebserver/scripts/ranger-admin-services.sh f2d2bf5 > security-admin/src/main/webapp/WEB-INF/log4j.properties 211de86 > > > Diff: https://reviews.apache.org/r/58660/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >