ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradeep Agrawal <pradeep.agra...@freestoneinfotech.com>
Subject Re: Review Request 66279: RANGER-2039 : Allow access to Audit tab for all users of role Keyadmin and KMS Auditor
Date Mon, 02 Apr 2018 05:40:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66279/#review200275
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/patch/PatchGrantAuditPermissionToKeyRoleUser_J10013.java
Lines 35 (patched)
<https://reviews.apache.org/r/66279/#comment280943>

    1) Patch Number J10013 is already in use now, Please change it to J10014.
    2) Add entry of this patch in the ranger_core_db_schema.sql file of all DB flavors.



security-admin/src/main/java/org/apache/ranger/patch/PatchGrantAuditPermissionToKeyRoleUser_J10013.java
Lines 88 (patched)
<https://reviews.apache.org/r/66279/#comment280944>

    Is it okay to continue the flow if either of them is null


- Pradeep Agrawal


On March 26, 2018, 1:02 p.m., Fatima Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66279/
> -----------------------------------------------------------
> 
> (Updated March 26, 2018, 1:02 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2039
>     https://issues.apache.org/jira/browse/RANGER-2039
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently by default users having Keyadmin or KMS auditor role doesn't get access to
Audits tab in Ranger UI, but ideally it should have audit access right so that when we login
through keyadmin and KMS Auditor we should be able to view the KMS related audits and user/groups
tab.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java b3d3e96 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchGrantAuditPermissionToKeyRoleUser_J10013.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66279/diff/1/
> 
> 
> Testing
> -------
> 
> Tested the by creating Auditor and KMS Auditor role user's get default access to users/groups
tab and Audit tab
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message