ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Review Request 66389: RANGER-2054:Fix new findBugs in RangerAdminClientImpl.java for kylin plugin test
Date Mon, 02 Apr 2018 07:13:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66389/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad,
Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat Ranganathan,
and Velmurugan Periasamy.


Bugs: RANGER-2054
    https://issues.apache.org/jira/browse/RANGER-2054


Repository: ranger


Description
-------

Fix new findBugs in RangerAdminClientImpl.java for kylin plugin test
________________________________________________________________________________________________________
*** CID 175091:  FindBugs: Internationalization  (FB.DM_DEFAULT_ENCODING)
/plugin-kylin/src/test/java/org/apache/ranger/authorization/kylin/authorizer/RangerAdminClientImpl.java:
68 in org.apache.ranger.authorization.kylin.authorizer.RangerAdminClientImpl.getServicePoliciesIfUpdated(long,
long)()
62             }
63     
64             java.nio.file.Path cachePath = FileSystems.getDefault()
65                     .getPath(basedir, "/src/test/resources/" + cacheFilename);
66             byte[] cacheBytes = Files.readAllBytes(cachePath);
67     
>>>     CID 175091:  FindBugs: Internationalization  (FB.DM_DEFAULT_ENCODING)
>>>     Found reliance on default encoding: new String(byte[]).
68             return gson.fromJson(new String(cacheBytes), ServicePolicies.class);
69         }
70     
71         @Override
72         public void grantAccess(GrantRevokeRequest request) throws Exception {
73

To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZSbhom32dlDl11LWEm9nX11zsOWMf5dv3Q9Mogo-2FGua3FsLRTFft2V-2FOFC9o0P2e0-3D_d04ZgyDzSjlwpjXIuOFYDNE6R93Lal83MDClQK32PZsnIXFWgRi957MYBuy-2FlDkytlroFFT4DodK8yWwhtaHLaX8VDTgQexZ1KpM2ghdONIK2s05PzHFJPHt35agqZ9nM-2FaTS-2BwGKR0yiHd9VqwUDlZAGDFlrUyAnUh6f6i-2B3anlkbZqOzVnGOBWkfRi-2BewYxNrjphgpV2suFoBTWVzO0g-3D-3D


Diffs
-----

  plugin-kylin/src/test/java/org/apache/ranger/authorization/kylin/authorizer/RangerAdminClientImpl.java
0c465b3 


Diff: https://reviews.apache.org/r/66389/diff/1/


Testing
-------

Tested


Thanks,

Qiang Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message