-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66357/#review200338
-----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java
Lines 81-84 (original), 133-141 (patched)
<https://reviews.apache.org/r/66357/#comment281054>
The getEncryptedMK function can return null. This segment code has logic error if the
getEncryptedMK return null.
kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java
Lines 81-84 (original), 133-141 (patched)
<https://reviews.apache.org/r/66357/#comment281055>
The getEncryptedMK function can return null. This segment code has logic error if the
getEncryptedMK return null.
kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java
Lines 211-219 (patched)
<https://reviews.apache.org/r/66357/#comment281056>
This segment code will throw exception if encryptedPwd.length > 1 and encryptedPwd.length
< 7
- Qiang Zhang
On March 29, 2018, 12:10 p.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66357/
> -----------------------------------------------------------
>
> (Updated March 29, 2018, 12:10 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni,
Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and
Velmurugan Periasamy.
>
>
> Bugs: RANGER-2017
> https://issues.apache.org/jira/browse/RANGER-2017
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Code Improvement To Follow Best Practices.
>
>
> Diffs
> -----
>
> kms/config/kms-webapp/dbks-site.xml 2fc5177
> kms/scripts/DBMK2HSM.sh 89c8c2d
> kms/scripts/HSMMK2DB.sh 2637cf6
> kms/scripts/importJCEKSKeys.sh d72c93e
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 5614c16
>
>
> Diff: https://reviews.apache.org/r/66357/diff/1/
>
>
> Testing
> -------
>
> 1. Verified Ranger Kms is working as expected.
> 2. Import/Export of key's working as expected.
>
>
> Thanks,
>
> bhavik patel
>
>
|