----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66245/#review200343 ----------------------------------------------------------- plugin-kafka/src/main/java/org/apache/ranger/services/kafka/RangerServiceKafka.java Lines 117 (patched) Did you test this function carefully? - Qiang Zhang On April 3, 2018, 7:21 a.m., Nikhil P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66245/ > ----------------------------------------------------------- > > (Updated April 3, 2018, 7:21 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2029 > https://issues.apache.org/jira/browse/RANGER-2029 > > > Repository: ranger > > > Description > ------- > > Ranger Kafka default policy creation improvement. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java d99f478 > plugin-kafka/src/main/java/org/apache/ranger/services/kafka/RangerServiceKafka.java b7bbe98 > > > Diff: https://reviews.apache.org/r/66245/diff/3/ > > > Testing > ------- > > 1) Tested if required policies are getting created when required service configs are given. > > > Thanks, > > Nikhil P > >