ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zsombor Gegesy <zsom...@apache.org>
Subject Review Request 66950: RANGER-2096 - remove dead code
Date Fri, 04 May 2018 12:01:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66950/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-2096
    https://issues.apache.org/jira/browse/RANGER-2096


Repository: ranger


Description
-------

There is unnecessary dead code in AbstractBaseResourceService.java, which stores the child
services in a service map, which is only called from RangerBizUtil.getVObject/getMObject methods,
which are only called from test method.

This can be removed safely.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java a0477fb1c 
  security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java
a64bb3048 
  security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 10e517fb1 


Diff: https://reviews.apache.org/r/66950/diff/1/


Testing
-------

Tested locally, and on a cluster


Thanks,

Zsombor Gegesy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message