ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Review Request 67206: RANGER-2108: Ensure that resource and access-type names in service definition are in lower case
Date Fri, 18 May 2018 04:40:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67206/
-----------------------------------------------------------

Review request for ranger and Madhan Neethiraj.


Bugs: RANGER-2108
    https://issues.apache.org/jira/browse/RANGER-2108


Repository: ranger


Description
-------

Ranger policy validations depend on resource names and access-type names being lower case.
A corresponding validation check should ensure that all resource and access-type names in
the service definitions too are in lower case, and fail to validate the service definition
if not so.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java ab120b729

  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java
d5f3fe5c9 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java
55973f545 
  agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefValidator.java
72c4520b7 


Diff: https://reviews.apache.org/r/67206/diff/1/


Testing
-------

Wrote corresponding unit test. Ran all unit tests successfully.


Thanks,

Abhay Kulkarni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message