From dev-return-17964-apmail-ranger-dev-archive=ranger.apache.org@ranger.apache.org Mon May 7 09:29:16 2018 Return-Path: X-Original-To: apmail-ranger-dev-archive@www.apache.org Delivered-To: apmail-ranger-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D0C6180AC for ; Mon, 7 May 2018 09:29:16 +0000 (UTC) Received: (qmail 62206 invoked by uid 500); 7 May 2018 09:29:16 -0000 Delivered-To: apmail-ranger-dev-archive@ranger.apache.org Received: (qmail 62143 invoked by uid 500); 7 May 2018 09:29:15 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 62127 invoked by uid 99); 7 May 2018 09:29:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 May 2018 09:29:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9C810C6866; Mon, 7 May 2018 09:29:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.601 X-Spam-Level: ** X-Spam-Status: No, score=2.601 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_MANYTO=0.2, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id n-RGsDBohDZ5; Mon, 7 May 2018 09:29:13 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8A64F5FAC8; Mon, 7 May 2018 09:29:13 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2F11CE010F; Mon, 7 May 2018 09:29:13 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DD648C4021A; Mon, 7 May 2018 09:29:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1389042768836881015==" MIME-Version: 1.0 Subject: Re: Review Request 66867: RANGER-2083 : Restrict KMS audit events to KMS related users only From: Fatima Khan To: Gautam Borad , Abhay Kulkarni , Ramesh Mani , Pradeep Agrawal , Sailaja Polavarapu , Selvamohan Neethiraj , Madhan Neethiraj , Don Bosco Durai Cc: Fatima Khan , ranger Date: Mon, 07 May 2018 09:29:12 -0000 Message-ID: <20180507092912.3180.60543@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Fatima Khan X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66867/ X-Sender: Fatima Khan References: <20180430061823.43939.83557@reviews-vm2.apache.org> In-Reply-To: <20180430061823.43939.83557@reviews-vm2.apache.org> Reply-To: Fatima Khan X-ReviewRequest-Repository: ranger --===============1389042768836881015== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66867/ ----------------------------------------------------------- (Updated May 7, 2018, 9:29 a.m.) Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu. Summary (updated) ----------------- RANGER-2083 : Restrict KMS audit events to KMS related users only Bugs: RANGER-2083 https://issues.apache.org/jira/browse/RANGER-2083 Repository: ranger Description ------- Only Keyadmin and KMS Auditor role users should be able to see KMS related audit logs. Diffs (updated) ----- security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java b7e045d security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 7dcb074 security-admin/src/main/webapp/scripts/utils/XAEnums.js 6e101bf security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b3da7b5 Diff: https://reviews.apache.org/r/66867/diff/2/ Changes: https://reviews.apache.org/r/66867/diff/1-2/ Testing ------- Testing done by checking that only Keyadmin and KMS Auditor role users are be able to see KMS related audit logs. Thanks, Fatima Khan --===============1389042768836881015==--