ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Review Request 67799: RANGER-2146: Tag attribute type needs to be initialized to a non-empty string
Date Mon, 02 Jul 2018 19:16:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67799/
-----------------------------------------------------------

Review request for ranger and Madhan Neethiraj.


Bugs: RANGER-2146
    https://issues.apache.org/jira/browse/RANGER-2146


Repository: ranger


Description
-------

As a part of tagsync updates for handling Atlas V2 APIs, a regression was introduced which
set tag attribute type to an empty string when creating service-tags structure from a AtlasEntityNotification
object. When saving attribute-definition to Oracle DB, this empty string tag was treated as
a null, which caused the database insert to fail (type column is defined as non-null field
in schema for x_tag_attr_def table).

As tag attribute type values are uninterpreted in Ranger, it is safe to set attribute type
to 'string' instead of to an empty string.


Diffs
-----

  tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/RangerAtlasEntityWithTags.java
c31c73c9f 


Diff: https://reviews.apache.org/r/67799/diff/1/


Testing
-------

Ran all unit tests successfully


Thanks,

Abhay Kulkarni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message