ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 68101: RANGER-2173: Optimize Trie constuction and Policy lookup
Date Tue, 31 Jul 2018 20:23:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68101/#review206679
-----------------------------------------------------------


Fix it, then Ship it!





agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java
Line 403 (original), 439 (patched)
<https://reviews.apache.org/r/68101/#comment289759>

    Consider replacing #439 with:
     addChild(child);


- Madhan Neethiraj


On July 31, 2018, 2:49 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68101/
> -----------------------------------------------------------
> 
> (Updated July 31, 2018, 2:49 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani,
and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2173
>     https://issues.apache.org/jira/browse/RANGER-2173
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger uses Trie data structure to look up policy resources for efficient access. Trie
tree may be optimized to contain fewer nodes and can be made less deep. This will allow faster
construction of Trie tree and faster lookup for a resource. This is done by using longest
common prefix strings instead of single character to organize Trie tree. Also added instrumentation
to measure performance.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java e7e8cf519

>   agents-common/src/test/resources/log4j.xml d1a6f1c8a 
> 
> 
> Diff: https://reviews.apache.org/r/68101/diff/3/
> 
> 
> Testing
> -------
> 
> Passes all unit tests
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message