ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Velmurugan Periasamy (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (RANGER-1918) Optimize logic and remove unnecessary temporary variables in YarnClient.class
Date Mon, 02 Jul 2018 20:21:00 GMT

     [ https://issues.apache.org/jira/browse/RANGER-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Velmurugan Periasamy updated RANGER-1918:
-----------------------------------------
    Fix Version/s:     (was: master)

> Optimize logic and remove unnecessary temporary variables in YarnClient.class
> -----------------------------------------------------------------------------
>
>                 Key: RANGER-1918
>                 URL: https://issues.apache.org/jira/browse/RANGER-1918
>             Project: Ranger
>          Issue Type: Improvement
>          Components: plugins
>    Affects Versions: master
>            Reporter: peng.jianhua
>            Assignee: peng.jianhua
>            Priority: Major
>
> 1.We have already determined the logic of the response! = Null and response.getStatus
()! = 200 in the getQueueResponse method, and do not need to be evaluated in the run method
of the getQueueResponse method. Move "response.close ();" into the getQueueResponse method.
> 2.There is no necessary to create so many useless temporary variables "String errMsg
= errMessage;"
>  just use errMessage is better practice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message