ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Review Request 68879: De-normalize schema for storing tags and related objects
Date Sat, 29 Sep 2018 00:01:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68879/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan
Periasamy.


Bugs: RANGER-2219
    https://issues.apache.org/jira/browse/RANGER-2219


Repository: ranger


Description
-------

Currently, tag-definitions, tags and service-resources are stored in database using a normalized
form. When constructing resource->tag mappings, this schema design may lead to a large
number of database accesses, thereby causing a major performance bottleneck when the number
of resource->tag associations is large.

Denormalized schema will reduce the number of database accesses, and improve overall performance
significantly.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java PRE-CREATION

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceResource.java d94867a50

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTag.java 743b02825 
  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTagDef.java 9f2982ff1 
  security-admin/db/mysql/patches/040-denormalize-tag-tables.sql PRE-CREATION 
  security-admin/db/oracle/patches/040-denormalize-tag-tables.sql PRE-CREATION 
  security-admin/db/postgres/patches/040-denormalize-tag-tables.sql PRE-CREATION 
  security-admin/db/sqlanywhere/patches/040-denormalize-tag-tables.sql PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql a79c95449 
  security-admin/db/sqlserver/patches/040-denormalize-tag-tables.sql PRE-CREATION 
  security-admin/scripts/db_setup.py d4f37ed6f 
  security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java 53683ec04 
  security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java 3234be6a2 
  security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceDao.java f87c0ae59 
  security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceElementDao.java 72fe2140b

  security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceElementValueDao.java
e726d047c 
  security-admin/src/main/java/org/apache/ranger/db/XXTagAttributeDao.java e361b33bd 
  security-admin/src/main/java/org/apache/ranger/db/XXTagAttributeDefDao.java 145399f1c 
  security-admin/src/main/java/org/apache/ranger/db/XXTagDao.java 77428dbf9 
  security-admin/src/main/java/org/apache/ranger/db/XXTagDefDao.java dfd2fcb5d 
  security-admin/src/main/java/org/apache/ranger/entity/XXServiceResource.java 961627a3c 
  security-admin/src/main/java/org/apache/ranger/entity/XXTag.java 9155385ec 
  security-admin/src/main/java/org/apache/ranger/entity/XXTagDef.java 818908ba8 
  security-admin/src/main/java/org/apache/ranger/patch/PatchForUpdatingTagsJson_J10020.java
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceTagsProcessor.java 9c19bb032

  security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java
d7256802a 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceServiceBase.java
6af682a81 
  security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java 82eb252e6

  security-admin/src/main/java/org/apache/ranger/service/RangerTagService.java 28b9115fa 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 4a7055dee 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 68908b205 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceTagProcessor.java PRE-CREATION

  security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefService.java 2ca0fd2fb

  security-admin/src/test/java/org/apache/ranger/service/TestRangerTagService.java PRE-CREATION



Diff: https://reviews.apache.org/r/68879/diff/1/


Testing
-------

Ran unit tests successfully.


Thanks,

Abhay Kulkarni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message