From dev-return-20376-apmail-ranger-dev-archive=ranger.apache.org@ranger.apache.org Tue Jan 29 20:12:37 2019 Return-Path: X-Original-To: apmail-ranger-dev-archive@www.apache.org Delivered-To: apmail-ranger-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 54EA818FA1 for ; Tue, 29 Jan 2019 20:12:37 +0000 (UTC) Received: (qmail 4630 invoked by uid 500); 29 Jan 2019 20:12:37 -0000 Delivered-To: apmail-ranger-dev-archive@ranger.apache.org Received: (qmail 4575 invoked by uid 500); 29 Jan 2019 20:12:37 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 4554 invoked by uid 99); 29 Jan 2019 20:12:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Jan 2019 20:12:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 25C2AC0607; Tue, 29 Jan 2019 20:12:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.701 X-Spam-Level: X-Spam-Status: No, score=0.701 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iTdUxMPEz8kf; Tue, 29 Jan 2019 20:12:33 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 40775623CA; Tue, 29 Jan 2019 20:12:33 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7E472E00CA; Tue, 29 Jan 2019 20:12:32 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 698DFC40009; Tue, 29 Jan 2019 20:12:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7914442024987275145==" MIME-Version: 1.0 Subject: Review Request 69856: RANGER-2328: Time-based policies do not work correctly if access time is not set in the authorization request From: Abhay Kulkarni To: Velmurugan Periasamy , Madhan Neethiraj , Ramesh Mani Cc: Abhay Kulkarni , ranger Date: Tue, 29 Jan 2019 20:12:32 -0000 Message-ID: <20190129201232.64365.54607@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Abhay Kulkarni X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69856/ X-Sender: Abhay Kulkarni Reply-To: Abhay Kulkarni X-ReviewRequest-Repository: ranger --===============7914442024987275145== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69856/ ----------------------------------------------------------- Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy. Bugs: RANGER-2328 https://issues.apache.org/jira/browse/RANGER-2328 Repository: ranger Description ------- Access authorization decision depends on the time of the access (which is retrieved from the authorization request) when evaluating Time-based policies. If access time is not set in the authorization request, current time should be used for evaluating access request. Diffs ----- agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java c3ed240ac agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java f8ca67e00 Diff: https://reviews.apache.org/r/69856/diff/1/ Testing ------- Tested with local VM Thanks, Abhay Kulkarni --===============7914442024987275145==--