From dev-return-20380-apmail-ranger-dev-archive=ranger.apache.org@ranger.apache.org Wed Jan 30 03:29:09 2019 Return-Path: X-Original-To: apmail-ranger-dev-archive@www.apache.org Delivered-To: apmail-ranger-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CC13C1812E for ; Wed, 30 Jan 2019 03:29:09 +0000 (UTC) Received: (qmail 67201 invoked by uid 500); 30 Jan 2019 03:29:09 -0000 Delivered-To: apmail-ranger-dev-archive@ranger.apache.org Received: (qmail 67138 invoked by uid 500); 30 Jan 2019 03:29:09 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 66990 invoked by uid 99); 30 Jan 2019 03:29:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Jan 2019 03:29:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 38D27C67A1; Wed, 30 Jan 2019 03:29:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.152 X-Spam-Level: *** X-Spam-Status: No, score=3.152 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id gFaVX83utsPJ; Wed, 30 Jan 2019 03:29:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6D3065F47B; Wed, 30 Jan 2019 03:20:10 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B8ABEE01C2; Wed, 30 Jan 2019 03:20:09 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7710BC40009; Wed, 30 Jan 2019 03:20:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2063092217575133407==" MIME-Version: 1.0 Subject: Re: Review Request 69740: RANGER-2322 - Use "TLS" in SSLContext.getInstance From: Pradeep Agrawal To: Pradeep Agrawal , Colm O hEigeartaigh , ranger Date: Wed, 30 Jan 2019 03:20:09 -0000 Message-ID: <20190130032009.64366.4102@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Pradeep Agrawal X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69740/ X-Sender: Pradeep Agrawal References: <20190114112059.64749.6087@reviews-vm2.apache.org> In-Reply-To: <20190114112059.64749.6087@reviews-vm2.apache.org> Reply-To: Pradeep Agrawal X-ReviewRequest-Repository: ranger --===============2063092217575133407== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69740/#review212436 ----------------------------------------------------------- Can you please add what all testing has been done with this patch. Thanks. - Pradeep Agrawal On Jan. 14, 2019, 11:20 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69740/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2019, 11:20 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-2322 > https://issues.apache.org/jira/browse/RANGER-2322 > > > Repository: ranger > > > Description > ------- > > There are a few instances in the code of SSLContext.getInstance("SSL"). Instead we should use "TLS". > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java f592ed4e7 > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSslHelper.java 2036661e8 > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java f653b81f3 > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java cb9b51c95 > > > Diff: https://reviews.apache.org/r/69740/diff/1/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > > --===============2063092217575133407==--