-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71992/
-----------------------------------------------------------
(Updated Jan. 16, 2020, 6:46 a.m.)
Review request for ranger, Jayendra Parab, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh,
Pradeep Agrawal, and Velmurugan Periasamy.
Changes
-------
Updated as suggested by Abhay
Bugs: RANGER-2695
https://issues.apache.org/jira/browse/RANGER-2695
Repository: ranger
Description
-------
Ranger creates ServiceDef(s) as part of initial setup. While creating these ServiceDef(s)
it refers respective JSON file. If display name for a ServiceDef is not provided OR it is
empty, ServiceDef's name should be used as DEFAULT displayName for that ServiceDef.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
e96f881ac
Diff: https://reviews.apache.org/r/71992/diff/3/
Changes: https://reviews.apache.org/r/71992/diff/2-3/
Testing
-------
Setup Ranger using following scenarios:
1. No displayName attribute in JSON file.
2. displayName attribute with empty string.
3. displayName attribute with string other than name.
Thanks,
Kishor Gollapalliwar
|