From dev-return-23827-apmail-ranger-dev-archive=ranger.apache.org@ranger.apache.org Wed Jan 8 07:04:16 2020 Return-Path: X-Original-To: apmail-ranger-dev-archive@www.apache.org Delivered-To: apmail-ranger-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 49ED41985B for ; Wed, 8 Jan 2020 07:04:16 +0000 (UTC) Received: (qmail 61799 invoked by uid 500); 8 Jan 2020 07:04:15 -0000 Delivered-To: apmail-ranger-dev-archive@ranger.apache.org Received: (qmail 61769 invoked by uid 500); 8 Jan 2020 07:04:15 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 61741 invoked by uid 99); 8 Jan 2020 07:04:14 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jan 2020 07:04:14 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4573CE0E2E; Wed, 8 Jan 2020 07:04:13 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A329DC40111; Wed, 8 Jan 2020 07:04:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1433817040844459551==" MIME-Version: 1.0 Subject: Re: Review Request 71964: RANGER-2687: NoClassDefFoundError when Ranger Knox plugin is enabled From: Ramesh Mani To: bhavik patel , Nitin Galave , Mehul Parikh , Gautam Borad , Abhay Kulkarni , Ramesh Mani , Velmurugan Periasamy , Nikhil P , Sailaja Polavarapu , Ankita Sinha , Madhan Neethiraj Cc: Pradeep Agrawal , ranger Date: Wed, 08 Jan 2020 07:04:12 -0000 Message-ID: <20200108070412.21447.13714@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ramesh Mani X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71964/ X-Sender: Ramesh Mani X-ReviewBoard-ShipIt: 1 References: <20200108050408.5286.78372@reviews-vm2.apache.org> In-Reply-To: <20200108050408.5286.78372@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Ramesh Mani X-ReviewRequest-Repository: ranger --===============1433817040844459551== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71964/#review219170 ----------------------------------------------------------- Ship it! Ship It! - Ramesh Mani On Jan. 8, 2020, 5:04 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71964/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2020, 5:04 a.m.) > > > Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2687 > https://issues.apache.org/jira/browse/RANGER-2687 > > > Repository: ranger > > > Description > ------- > > ** Problem Statement: ** > > RANGER-2555 introduced RangerRESTClient dependency on RangerAdminJersey2RESTClient. Which forces Java to pull in the RangerRESTClient from RangerAdminJersey2RESTClient. This causes the classes to try to be loaded even though its a static method for getURLs. > > ** Proposed solution: ** > > Moved function RangerRESTClient.getURLs() to StringUtil class which does not pulls in any other dependencies. RangerAdminRESTClient and RangerAdminJersey2RESTClient can refer to it. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/authorization/utils/StringUtil.java 17a0651f3 > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java 0f44a5dbe > knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java 8ac62d3df > > > Diff: https://reviews.apache.org/r/71964/diff/1/ > > > Testing > ------- > > Replaced the jar with the patch and error is not appearing now. > > > Thanks, > > Pradeep Agrawal > > --===============1433817040844459551==--