From dev-return-23797-apmail-ranger-dev-archive=ranger.apache.org@ranger.apache.org Mon Jan 6 10:23:04 2020 Return-Path: X-Original-To: apmail-ranger-dev-archive@www.apache.org Delivered-To: apmail-ranger-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 5FD4A19458 for ; Mon, 6 Jan 2020 10:23:04 +0000 (UTC) Received: (qmail 83772 invoked by uid 500); 6 Jan 2020 10:23:03 -0000 Delivered-To: apmail-ranger-dev-archive@ranger.apache.org Received: (qmail 83683 invoked by uid 500); 6 Jan 2020 10:23:03 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 83650 invoked by uid 99); 6 Jan 2020 10:23:03 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jan 2020 10:23:03 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 799C3E300F for ; Mon, 6 Jan 2020 10:23:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 4397A7822EA for ; Mon, 6 Jan 2020 10:23:00 +0000 (UTC) Date: Mon, 6 Jan 2020 10:23:00 +0000 (UTC) From: "Jiayi Liu (Jira)" To: dev@ranger.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (RANGER-2667) Running the disable-presto-plugin.sh script will always get stuck MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/RANGER-2667?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiayi Liu updated RANGER-2667: ------------------------------ Attachment: 0001-RANGER-2667.patch > Running the disable-presto-plugin.sh script will always get stuck > ----------------------------------------------------------------- > > Key: RANGER-2667 > URL: https://issues.apache.org/jira/browse/RANGER-2667 > Project: Ranger > Issue Type: Bug > Components: plugins > Affects Versions: 2.0.0 > Reporter: Jiayi Liu > Priority: Major > Attachments: 0001-RANGER-2667.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Running the disable-presto-plugin.sh script will always get stuck. Becaus= e the script sets the=20 > controlName to an empty string and passes it to the function=C2=A0addOrUp= datePropertyToFile when disable the presto plugin. If controlName is an emp= ty string, addOrUpdatePropertyToFile will ignore this parameter and let fn = to be the second parameter. So $3 passed to checkPropertyInFile will be emp= ty. In checkPropertyInFile, if the second parameter is empty, the sed comma= nd will never return, and the disable-presto-plugin.sh script will always g= et stuck. > We should pass the default value of access-control.name and set controlNa= me to be allow-all when disable presto plugin.=20 > The default value of access-control.name can be seen here: https://presto= db.io/docs/current/security/built-in-system-access-control.html > The pull request: https://github.com/apache/ranger/pull/45 -- This message was sent by Atlassian Jira (v8.3.4#803005)