ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradeep Agrawal <pradeepagrawal8...@gmail.com>
Subject Re: Review Request 72166: RANGER-2713: Remove audit fields from XXPolicyRef objects
Date Tue, 03 Mar 2020 12:28:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72166/#review219731
-----------------------------------------------------------



>From which version upgrade case has been tested ? can you try from ranger-0.7 also if
it was not tested?

- Pradeep Agrawal


On 二月 26, 2020, 10:18 p.m., Andrew Luo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72166/
> -----------------------------------------------------------
> 
> (Updated 二月 26, 2020, 10:18 p.m.)
> 
> 
> Review request for ranger and Pradeep Agrawal.
> 
> 
> Bugs: RANGER-2713
>     https://issues.apache.org/jira/browse/RANGER-2713
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> XXPolicyRef objects have fields such as create time, update time, added by user ID, updated
by user ID, but there fields are entirely useless since they are all copied from the XXPolicy
object. In addition, while improving performance for creation of policies with large numbers
of users, we discovered that a lot of time was being spent in JPA converting these Date objects
especially. After removing these fields we saw a significant performance improvement (a secondary
benefit is less database space usage).
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 47618f6b3 
>   security-admin/db/mysql/patches/046-drop-audit-columns-from-policy-ref-tables.sql PRE-CREATION

>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql e59e7de61 
>   security-admin/db/oracle/patches/046-drop-audit-columns-from-policy-ref-tables.sql
PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 37ea61912

>   security-admin/db/postgres/patches/046-drop-audit-columns-from-policy-ref-tables.sql
PRE-CREATION 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql bd1c47cc4

>   security-admin/db/sqlanywhere/patches/046-drop-audit-columns-from-policy-ref-tables.sql
PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 22e1746f2

>   security-admin/db/sqlserver/patches/046-drop-audit-columns-from-policy-ref-tables.sql
PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java baacfa4d8

>   security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefAccessType.java 6af8f99f4

>   security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefCondition.java 4f4409d6a

>   security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefDataMaskType.java
cb926740e 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefGroup.java 32a1b9f24

>   security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefResource.java 115064621

>   security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefRole.java 7aee502e0

>   security-admin/src/main/java/org/apache/ranger/entity/XXPolicyRefUser.java 8dfb92833

>   security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java 85e457efa

>   security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 69c8a4cb6

> 
> 
> Diff: https://reviews.apache.org/r/72166/diff/1/
> 
> 
> Testing
> -------
> 
> Fresh install and upgrade tested on all 5 databases (tested service and policy creation)
> 
> Also tested user deletion on MySQL:
> 
> 1. Created new user
> 2. Logged in as new user, created a policy
> 3. Logged back in as original user, delete user that created policy
> 4. Verified no errors, policy is still present/correct
> 
> Also searched the source code and JPA queries xml for other references to these fields
> 
> 
> Thanks,
> 
> Andrew Luo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message