ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradeep Agrawal <pradeepagrawal8...@gmail.com>
Subject Re: Review Request 72219: RANGER-2753: Optimize populating user group mappings from DB
Date Tue, 10 Mar 2020 05:04:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72219/#review219857
-----------------------------------------------------------




security-admin/src/main/resources/META-INF/jpa_named_queries.xml
Lines 133 (patched)
<https://reviews.apache.org/r/72219/#comment308106>

    WHERE user.id=groupUser.userId and group.id=groupUser.parentGroupId could be faster


- Pradeep Agrawal


On 三月 9, 2020, 4:44 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72219/
> -----------------------------------------------------------
> 
> (Updated 三月 9, 2020, 4:44 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2753
>     https://issues.apache.org/jira/browse/RANGER-2753
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added DB query to retrive user group mappings from x_user, x_group, and x_group_users
tables. This will eliminate multiple calls to database while populating user store information.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerUserStore.java dfe742f96

>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 88a4330f1 
>   security-admin/src/main/java/org/apache/ranger/common/RangerUserStoreCache.java 8ffc98cc7

>   security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java cea90c165 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml f23bf2e65 
> 
> 
> Diff: https://reviews.apache.org/r/72219/diff/1/
> 
> 
> Testing
> -------
> 
> Verified all the unit tests are passed.
> Also verified functionality with more no. of entries in users and group and mappings
tables.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message