-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72302/#review220175
-----------------------------------------------------------
Fix it, then Ship it!
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
Lines 76 (patched)
<https://reviews.apache.org/r/72302/#comment308494>
String conditionType = condition != null ? condition.getType() : null;
"failed to initialize condition " + conditionType + ": script engine '" + engineName +
"' was not created"
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
Lines 131 (patched)
<https://reviews.apache.org/r/72302/#comment308495>
String conditionType = condition != null ? condition.getType() : null;
"failed to evaluate condition " + conditionType + ": script is empty"
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
Lines 135 (patched)
<https://reviews.apache.org/r/72302/#comment308496>
String conditionType = condition != null ? condition.getType() : null;
"failed to evaluate condition " + conditionType + ": script engine not found"
- Madhan Neethiraj
On April 1, 2020, 5:50 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72302/
> -----------------------------------------------------------
>
> (Updated April 1, 2020, 5:50 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2773
> https://issues.apache.org/jira/browse/RANGER-2773
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Failure during initialization of RangerScriptConditionEvaluator is not reported. Such
failure should be clearly reported as an error. Any methods called on incorrectly initialized
RangerScriptConditionEvaluator also need to report error.
>
> Note that this fix only logs an error.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
5b6653901
>
>
> Diff: https://reviews.apache.org/r/72302/diff/1/
>
>
> Testing
> -------
>
> Tested in a live cluster.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
|