ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 72312: RANGER-2777:Ranger Knox Plugin failed to download Roles
Date Fri, 03 Apr 2020 07:21:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72312/#review220210
-----------------------------------------------------------


Fix it, then Ship it!





knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java
Line 237 (original), 237 (patched)
<https://reviews.apache.org/r/72312/#comment308515>

    - RangerAdminRESTClient uses REST_URL_SERVICE_SERCURE_GET_USER_GROUP_ROLES; here REST_URL_ROLE_GET_FOR_SECURE_SERVICE_IF_UPDATED
is used. They both are assigned the same value. Please review and remove duplicate.
    - Also, _baseUrl, and _utils are no more needed outside the constructor. Please review
and remove.


- Madhan Neethiraj


On April 3, 2020, 6:58 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72312/
> -----------------------------------------------------------
> 
> (Updated April 3, 2020, 6:58 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2777
>     https://issues.apache.org/jira/browse/RANGER-2777
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2777:Ranger Knox Plugin failed to download Roles
> 
> 
> Diffs
> -----
> 
>   knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java
b2184b6 
> 
> 
> Diff: https://reviews.apache.org/r/72312/diff/1/
> 
> 
> Testing
> -------
> 
> Tested in local vm for Roles Donwload in Knox plugin
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message