ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 72272: Upgrade and improve Presto plugin
Date Mon, 13 Apr 2020 04:40:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72272/#review220292
-----------------------------------------------------------




plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
Lines 206 (patched)
<https://reviews.apache.org/r/72272/#comment308628>

    None of the mask-types have token {type}; what is the use case to replace this token in
the transformer?



plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
Line 140 (original), 307 (patched)
<https://reviews.apache.org/r/72272/#comment308629>

    Are info level logs here and rest of this class intentional? If not, consider changing
to debug level.



plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
Line 179 (original), 363 (patched)
<https://reviews.apache.org/r/72272/#comment308630>

    denyCommentTable() => denyShowTables() ?


- Madhan Neethiraj


On April 10, 2020, 6 p.m., Bolke de Bruin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72272/
> -----------------------------------------------------------
> 
> (Updated April 10, 2020, 6 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Ramesh
Mani.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/RANGER-2754
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-2754
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Upgrade and improve Presto plugin
> - Presto SQL 331 has changed its security API and has Row level / column masking functionality
> - Upgraded Hadoop dependency to 3.1.3 (from 3.1.1) due to improved security handling
> - New features like session properties and system properties
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json 56a8f5ac0

>   distro/src/main/assembly/plugin-presto.xml d2075bfe7 
>   plugin-presto/pom.xml b63f7dede 
>   plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
3ab63f590 
>   plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerAdminClientImpl.java
PRE-CREATION 
>   plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlTest.java
PRE-CREATION 
>   plugin-presto/src/test/resources/log4j.properties PRE-CREATION 
>   plugin-presto/src/test/resources/presto-policies.json PRE-CREATION 
>   plugin-presto/src/test/resources/ranger-presto-security.xml PRE-CREATION 
>   pom.xml b62d9b663 
>   ranger-presto-plugin-shim/pom.xml d8ff88d0f 
>   ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerConfig.java
67b0d2434 
>   ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
e89f646e1 
> 
> 
> Diff: https://reviews.apache.org/r/72272/diff/6/
> 
> 
> Testing
> -------
> 
> - New Unit tests added
> - Tested locally in production
> 
> 
> Thanks,
> 
> Bolke de Bruin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message