ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradeep Agrawal <pradeepagrawal8...@gmail.com>
Subject Re: Review Request 72272: Upgrade and improve Presto plugin
Date Wed, 22 Apr 2020 06:55:48 GMT


> On April 5, 2020, 6:09 p.m., Madhan Neethiraj wrote:
> > ranger-presto-plugin-shim/pom.xml
> > Lines 93 (patched)
> > <https://reviews.apache.org/r/72272/diff/2/?file=2215820#file2215820line93>
> >
> >     The changes in this module don't seem to refer hadoop-hdfs library contents
directly. Is it necessary to explicitly add this dependency?
> 
> Bolke de Bruin wrote:
>     I'm not getting it into the assembly otherwise for auditing purposes? please advise.
> 
> Pradeep Agrawal wrote:
>     try adding in https://github.com/apache/ranger/blob/master/distro/src/main/assembly/plugin-presto.xml
>     make sure you are adding in the directory where you want it.
> 
> Bolke de Bruin wrote:
>     That's what I did. The items are not picked up if the dependency is not present in
the pom?

Yes, you are  right. it will not be picked up by own. it can be pick in below conditions
1) you explicitely add the dependency in pom.
2) some other dependencies pulls these dependencies libraries.


- Pradeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72272/#review220223
-----------------------------------------------------------


On April 21, 2020, 11:43 a.m., Bolke de Bruin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72272/
> -----------------------------------------------------------
> 
> (Updated April 21, 2020, 11:43 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Ramesh
Mani.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/RANGER-2754
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-2754
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Upgrade and improve Presto plugin
> - Presto SQL 331 has changed its security API and has Row level / column masking functionality
> - Upgraded Hadoop dependency to 3.1.3 (from 3.1.1) due to improved security handling
> - New features like session properties and system properties
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json 56a8f5ac0

>   distro/src/main/assembly/plugin-presto.xml d2075bfe7 
>   plugin-presto/pom.xml b63f7dede 
>   plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
3ab63f590 
>   plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerAdminClientImpl.java
PRE-CREATION 
>   plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlTest.java
PRE-CREATION 
>   plugin-presto/src/test/resources/log4j.properties PRE-CREATION 
>   plugin-presto/src/test/resources/presto-policies.json PRE-CREATION 
>   plugin-presto/src/test/resources/ranger-presto-security.xml PRE-CREATION 
>   pom.xml 992c3654e 
>   ranger-presto-plugin-shim/pom.xml d8ff88d0f 
>   ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerConfig.java
67b0d2434 
>   ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
e89f646e1 
> 
> 
> Diff: https://reviews.apache.org/r/72272/diff/10/
> 
> 
> Testing
> -------
> 
> - New Unit tests added
> - Tested locally in production
> 
> 
> Thanks,
> 
> Bolke de Bruin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message