From dev-return-24875-apmail-ranger-dev-archive=ranger.apache.org@ranger.apache.org Wed Apr 15 15:04:19 2020 Return-Path: X-Original-To: apmail-ranger-dev-archive@www.apache.org Delivered-To: apmail-ranger-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 100DD19C4B for ; Wed, 15 Apr 2020 15:04:18 +0000 (UTC) Received: (qmail 7928 invoked by uid 500); 15 Apr 2020 15:04:16 -0000 Delivered-To: apmail-ranger-dev-archive@ranger.apache.org Received: (qmail 7899 invoked by uid 500); 15 Apr 2020 15:04:16 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 7811 invoked by uid 99); 15 Apr 2020 15:04:15 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2020 15:04:15 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 21B7DE2CA2; Wed, 15 Apr 2020 15:04:15 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DF887C400A8; Wed, 15 Apr 2020 15:04:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7980274112621714933==" MIME-Version: 1.0 Subject: Re: Review Request 72272: Upgrade and improve Presto plugin From: Pradeep Agrawal To: Pradeep Agrawal , Mehul Parikh , Madhan Neethiraj , Ramesh Mani Cc: Bolke de Bruin , ranger Date: Wed, 15 Apr 2020 15:04:14 -0000 Message-ID: <20200415150414.7257.46082@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Pradeep Agrawal X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72272/ X-Sender: Pradeep Agrawal References: <20200405180932.3631.46748@reviews-vm2.apache.org> In-Reply-To: <20200405180932.3631.46748@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerAdminClientImpl.java X-ReviewBoard-Diff-For: plugin-presto/src/test/resources/presto-policies.json X-ReviewBoard-Diff-For: plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlTest.java X-ReviewBoard-Diff-For: plugin-presto/src/test/resources/log4j.properties X-ReviewBoard-Diff-For: plugin-presto/src/test/resources/ranger-presto-security.xml Reply-To: Pradeep Agrawal X-ReviewRequest-Repository: ranger --===============7980274112621714933== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On 四月 5, 2020, 6:09 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > > Lines 96 (patched) > > > > > > To update existing Ranger instances with these service-def changes, consider adding a Java patch similar to PatchForAtlasToAddEntityLabelAndBusinessMetadata_J10034.java that handles recent updates to Atlas service-def. > > > > This can be taken up in a subsequent commit. Created RANGER-2795 to track this separately. > On 四月 5, 2020, 6:09 p.m., Madhan Neethiraj wrote: > > ranger-presto-plugin-shim/pom.xml > > Lines 93 (patched) > > > > > > The changes in this module don't seem to refer hadoop-hdfs library contents directly. Is it necessary to explicitly add this dependency? > > Bolke de Bruin wrote: > I'm not getting it into the assembly otherwise for auditing purposes? please advise. try adding in https://github.com/apache/ranger/blob/master/distro/src/main/assembly/plugin-presto.xml make sure you are adding in the directory where you want it. > On 四月 5, 2020, 6:09 p.m., Madhan Neethiraj wrote: > > ranger-presto-plugin-shim/pom.xml > > Lines 134 (patched) > > > > > > The changes in this module don't seem to refer protobuf-java library contents directly. Is it necessary to explicitly add this dependency? > > Bolke de Bruin wrote: > Idem as above. How to get it in the assembly? It seems not to be included otherwise (struggling with that overall btw) try adding in https://github.com/apache/ranger/blob/master/distro/src/main/assembly/plugin-presto.xml make sure you are adding in the directory where you want it. - Pradeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72272/#review220223 ----------------------------------------------------------- On 四月 15, 2020, 6:49 a.m., Bolke de Bruin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72272/ > ----------------------------------------------------------- > > (Updated 四月 15, 2020, 6:49 a.m.) > > > Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Ramesh Mani. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-2754 > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-2754 > > > Repository: ranger > > > Description > ------- > > Upgrade and improve Presto plugin > - Presto SQL 331 has changed its security API and has Row level / column masking functionality > - Upgraded Hadoop dependency to 3.1.3 (from 3.1.1) due to improved security handling > - New features like session properties and system properties > > > Diffs > ----- > > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json 56a8f5ac0 > distro/src/main/assembly/plugin-presto.xml d2075bfe7 > plugin-presto/pom.xml b63f7dede > plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java 3ab63f590 > plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerAdminClientImpl.java PRE-CREATION > plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlTest.java PRE-CREATION > plugin-presto/src/test/resources/log4j.properties PRE-CREATION > plugin-presto/src/test/resources/presto-policies.json PRE-CREATION > plugin-presto/src/test/resources/ranger-presto-security.xml PRE-CREATION > pom.xml b62d9b663 > ranger-presto-plugin-shim/pom.xml d8ff88d0f > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerConfig.java 67b0d2434 > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java e89f646e1 > > > Diff: https://reviews.apache.org/r/72272/diff/8/ > > > Testing > ------- > > - New Unit tests added > - Tested locally in production > > > Thanks, > > Bolke de Bruin > > --===============7980274112621714933==--