ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradeep Agrawal <pradeepagrawal8...@gmail.com>
Subject Re: Review Request 72645: RANGER-2895: Replace c3p0 connection pool with HikariCP, upgrading MySQL connector and Eclipselink
Date Mon, 06 Jul 2020 03:56:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72645/#review221128
-----------------------------------------------------------



I would like you to test this patch in all other db flavors ranger is supported. They are
Mysql, oracle, postgres, sqlanywhere, microsoft sqlserver

- Pradeep Agrawal


On July 5, 2020, 7:15 p.m., Bill Ricky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72645/
> -----------------------------------------------------------
> 
> (Updated July 5, 2020, 7:15 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2895
>     https://issues.apache.org/jira/browse/RANGER-2895
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> We should replace c3p0 with [HikariCP|https://github.com/brettwooldridge/HikariCP]. HikariCP
is much faster and less error prone. HikariCP is more popular with 13.2k+ stars on its github.
There were no more new commits since Nov 18, 2019 in [c3p0|https://github.com/swaldman/c3p0/commits/master].
> 
> [MySQL connector|https://github.com/mysql/mysql-connector-j] and [Eclipselink|https://github.com/eclipse-ee4j/eclipselink]
should be upgraded to the latest stable versions as well to include many essential bugfixes.
> 
> 
> Diffs
> -----
> 
>   pom.xml 5bfd08df2 
>   security-admin/pom.xml 745dbfe8c 
>   security-admin/scripts/ranger-admin-site-template.xml 72ff66eaf 
>   security-admin/scripts/setup.sh 949c24244 
>   security-admin/scripts/upgrade_admin.py 10fa485bd 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml fcd4bd0ee

>   security-admin/src/main/webapp/META-INF/applicationContext.xml b24f4d4ac 
> 
> 
> Diff: https://reviews.apache.org/r/72645/diff/1/
> 
> 
> Testing
> -------
> 
> 1.Compilation OK
> 2.Already used in production environment
> 
> 
> Thanks,
> 
> Bill Ricky
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message