From dev-return-26013-apmail-ranger-dev-archive=ranger.apache.org@ranger.apache.org Tue Jul 14 17:44:49 2020 Return-Path: X-Original-To: apmail-ranger-dev-archive@www.apache.org Delivered-To: apmail-ranger-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id E2DD919AF7 for ; Tue, 14 Jul 2020 17:44:47 +0000 (UTC) Received: (qmail 93281 invoked by uid 500); 14 Jul 2020 17:44:47 -0000 Delivered-To: apmail-ranger-dev-archive@ranger.apache.org Received: (qmail 93261 invoked by uid 500); 14 Jul 2020 17:44:47 -0000 Mailing-List: contact dev-help@ranger.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ranger.apache.org Delivered-To: mailing list dev@ranger.apache.org Received: (qmail 93243 invoked by uid 99); 14 Jul 2020 17:44:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jul 2020 17:44:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2EC70C20A5 for ; Tue, 14 Jul 2020 17:44:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.999 X-Spam-Level: *** X-Spam-Status: No, score=3.999 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.2, KAM_DMARC_NONE=0.25, KAM_DMARC_STATUS=0.01, KAM_LAZY_DOMAIN_SECURITY=1, KHOP_HELO_FCRDNS=0.085, NML_ADSP_CUSTOM_MED=1.2, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id kSmDZI8wNkfK for ; Tue, 14 Jul 2020 17:44:45 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=95.217.165.199; helo=reviews-vm-he-fi.apache.org; envelope-from=noreply@reviews.apache.org; receiver= Received: from reviews-vm-he-fi.apache.org (static.199.165.217.95.clients.your-server.de [95.217.165.199]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTP id 9364DBE314 for ; Tue, 14 Jul 2020 17:44:44 +0000 (UTC) Received: from reviews-vm-he-fi.apache.org (reviews-vm-he-fi.apache.org [127.0.0.1]) by reviews-vm-he-fi.apache.org (Postfix) with ESMTP id 6C3B0160F03; Tue, 14 Jul 2020 17:44:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0652448772292880321==" MIME-Version: 1.0 Subject: Re: Review Request 72645: RANGER-2895: Replace c3p0 connection pool with HikariCP, upgrading MySQL connector and Eclipselink From: Bill Ricky To: Pradeep Agrawal , Bill Ricky , ranger Date: Tue, 14 Jul 2020 17:44:42 -0000 Message-ID: <20200714174442.21172.29131@reviews-vm-he-fi.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Bill Ricky X-ReviewGroup: ranger X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72645/ X-Sender: Bill Ricky References: <20200706035644.17393.77821@reviews-vm-he-fi.apache.org> In-Reply-To: <20200706035644.17393.77821@reviews-vm-he-fi.apache.org> Reply-To: Bill Ricky X-ReviewRequest-Repository: ranger --===============0652448772292880321== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On 七月 6, 2020, 3:56 a.m., Pradeep Agrawal wrote: > > I would like you to test this patch in all other db flavors ranger is supported. They are Mysql, oracle, postgres, sqlanywhere, microsoft sqlserver It took me some time to install all other kinds of databases. All tests are ok. HikariCP and EclipseLink work fine with all the databases above. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72645/#review221128 ----------------------------------------------------------- On 七月 5, 2020, 7:15 p.m., Bill Ricky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72645/ > ----------------------------------------------------------- > > (Updated 七月 5, 2020, 7:15 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2895 > https://issues.apache.org/jira/browse/RANGER-2895 > > > Repository: ranger > > > Description > ------- > > We should replace c3p0 with [HikariCP|https://github.com/brettwooldridge/HikariCP]. HikariCP is much faster and less error prone. HikariCP is more popular with 13.2k+ stars on its github. There were no more new commits since Nov 18, 2019 in [c3p0|https://github.com/swaldman/c3p0/commits/master]. > > [MySQL connector|https://github.com/mysql/mysql-connector-j] and [Eclipselink|https://github.com/eclipse-ee4j/eclipselink] should be upgraded to the latest stable versions as well to include many essential bugfixes. > > > Diffs > ----- > > pom.xml 5bfd08df2 > security-admin/pom.xml 745dbfe8c > security-admin/scripts/ranger-admin-site-template.xml 72ff66eaf > security-admin/scripts/setup.sh 949c24244 > security-admin/scripts/upgrade_admin.py 10fa485bd > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml fcd4bd0ee > security-admin/src/main/webapp/META-INF/applicationContext.xml b24f4d4ac > > > Diff: https://reviews.apache.org/r/72645/diff/1/ > > > Testing > ------- > > 1.Compilation OK > 2.Already used in production environment > > > Thanks, > > Bill Ricky > > --===============0652448772292880321==--