rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ciancetta, Jesse E." <jc...@mitre.org>
Subject RE: [jira] [Commented] (RAVE-58) Refactor Delete
Date Fri, 17 Jun 2011 13:32:00 GMT
>-----Original Message-----
>From: Franklin, Matthew B. [mailto:mfranklin@mitre.org]
>Sent: Friday, June 17, 2011 8:13 AM
>To: rave-dev@incubator.apache.org
>Subject: Re: [jira] [Commented] (RAVE-58) Refactor Delete
>
>On 6/16/11 9:37 AM, "Jasha Joachimsthal (JIRA)" <jira@apache.org> wrote:
>
>>
>>    [
>>https://issues.apache.org/jira/browse/RAVE-
>58?page=com.atlassian.jira.plug
>>in.system.issuetabpanels:comment-
>tabpanel&focusedCommentId=13050415#commen
>>t-13050415 ]
>>
>>Jasha Joachimsthal commented on RAVE-58:
>>----------------------------------------
>>
>>The scripts can be loaded from the bottom of the page without changing
>>the delete logic just by looping over the widgetRegions twice. A user
>>will probably not have hundreds of widgets installed. I'll work further
>>on moving the logic into external js includes.
>
>This ticket was more of a placeholder to simplify delete.  There shouldn't
>be a need to depend on the region that the widget is currently in to
>delete it.  Feel free to move the JS, but I recommend keep this ticket
>open so we can simplify delete.
>

To expand a bit on how delete might be able to be simplified (in case Jasha was planning to
pick up that piece too) -- I think we could probably add support for deleting a RegionWidget
instance to the REST API we currently have in place, so then deleting a RegionWidget instance
becomes a simple HTTP DELETE call to /api/rest/regionWidgets/{regionWidgetId}.  JPA should
handle all the details of removing that RegionWidget instance from any other managed entities
that have references to it.  I'm not 100% certain that all the JPA relationships are properly
configured right now to make that happen, but it should be possible nonetheless.

I think in general we should try to do as much as we can via the REST API and reserve the
RPC API for things that cannot easily be modeled as a RESTful operation.  Thoughts on that
from others?

>-Matt
>
>>
>>> Refactor Delete
>>> ---------------
>>>
>>>                 Key: RAVE-58
>>>                 URL: https://issues.apache.org/jira/browse/RAVE-58
>>>             Project: Rave
>>>          Issue Type: Bug
>>>    Affects Versions: 0.1-INCUBATING
>>>            Reporter: Matt Franklin
>>>            Assignee: Jasha Joachimsthal
>>>             Fix For: 0.2-INCUBATING
>>>
>>>
>>> Refactor delete widget so that it does not depend on tracking region in
>>>the client.
>>> Update delete initialization so that scripts can be loaded from the
>>>bottom of the page and all logic is in external js include
>>
>>--
>>This message is automatically generated by JIRA.
>>For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>


Mime
View raw message