rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfrank...@apache.org
Subject Re: Review Request: RAVE-571 - Adds the ability to pass parameters when switching between views
Date Sat, 21 Apr 2012 00:30:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4834/#review7103
-----------------------------------------------------------

Ship it!


LGTM.  I will apply this tonight.

- mfranklin


On 2012-04-20 23:26:33, Chris Geer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4834/
> -----------------------------------------------------------
> 
> (Updated 2012-04-20 23:26:33)
> 
> 
> Review request for rave.
> 
> 
> Summary
> -------
> 
> RAVE-571 - Adds the ability to pass parameters when switching between views
> 
> 
> Diffs
> -----
> 
>   /trunk/rave-demo-gadgets/src/main/webapp/canvas-nav.xml 1328478 
>   /trunk/rave-portal-resources/src/main/webapp/script/rave.js 1328478 
>   /trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js 1328478 
> 
> Diff: https://reviews.apache.org/r/4834/diff
> 
> 
> Testing
> -------
> 
> Updated the canvas-nav gadget to demonstrate it working with passing a parameter and
also not passing a parameter (non-breaking change)
> 
> 
> Thanks,
> 
> Chris
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message