rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Sharples <p.sharp...@bolton.ac.uk>
Subject Re: Review Request: RAVE-103. Support shared spaces.
Date Wed, 25 Apr 2012 21:23:00 GMT
On 25/04/2012 20:35, Franklin, Matthew B. wrote:
>> -----Original Message-----
>> From: Jasha Joachimsthal [mailto:j.joachimsthal@onehippo.com]
>> Sent: Wednesday, April 25, 2012 12:16 PM
>> To: dev@rave.apache.org
>> Subject: Re: Review Request: RAVE-103. Support shared spaces.
>>
>> I'm trying to review it, but run into major merge conflicts since the
>> bootstrap changes in the portal UI. :(
> Paul, could you re-spin the patch?  I know its merging on your side, but you know the
code changes the best...

No worries, I'll get onto it tomorrow.

Paul

>
>>
>> On 24 April 2012 17:18, Franklin, Matthew B.<mfranklin@mitre.org>  wrote:
>>
>>> Hi Paul,
>>>
>>> I will try to review this before end of day tomorrow.  Anyone else want to
>>> look it over also?  It represents a pretty big change.
>>>
>>> -Matt
>>>> -----Original Message-----
>>>> From: Paul Sharples [mailto:p.sharples@bolton.ac.uk]
>>>> Sent: Monday, April 23, 2012 7:55 AM
>>>> To: Paul Sharples; rave
>>>> Subject: Review Request: RAVE-103. Support shared spaces.
>>>>
>>>>
>>>> -----------------------------------------------------------
>>>> This is an automatically generated e-mail. To reply, visit:
>>>> https://reviews.apache.org/r/4843/
>>>> -----------------------------------------------------------
>>>>
>>>> Review request for rave.
>>>>
>>>>
>>>> Summary
>>>> -------
>>>>
>>>> RAVE-103. support shared spaces.  I've submitted this patch here rather
>>> than
>>>> commit the code directly, as the changes affect the UI and I wanted a
>>> request
>>>> for comments type approach first. This is a page sharing patch which
>>> allows a
>>>> user to share his/her page with other rave users, as well as also
>>> allowing the
>>>> user to revoke page shares. A user who receives a shared page can opt to
>>>> confirm the share (meaning the page will always appear in his/her tabbed
>>>> page list or decline it (i.e I don't want this shared page).  There's
>>> still more to
>>>> improve on this, but the basic functionality is there. Note I have
>>> removed the
>>>> render sequencing away from the page object into the new pageUser
>> object.
>>>> This is because with the possibility of having several users of a page,
>>> they all
>>>> need to have their own page render sequencing. See RAVE-103.
>>>>
>>>>
>>>> Diffs
>>>> -----
>>>>
>>>>   /trunk/rave-components/rave-
>>> core/src/test/java/org/apache/rave/portal/repository/impl/JpaPageReposit
>> o
>>>> ryTest.java 1308947
>>>>   /trunk/rave-components/rave-
>>> core/src/test/java/org/apache/rave/portal/service/impl/DefaultPageService
>> T
>>>> est.java 1327947
>>>>   /trunk/rave-components/rave-core/src/test/resources/test_data.sql
>>>> 1308947
>>>>   /trunk/rave-components/rave-
>>>> web/src/main/java/org/apache/rave/portal/web/api/rpc/UserApi.java
>> PRE-
>>>> CREATION
>>>>   /trunk/rave-components/rave-
>>>> web/src/main/java/org/apache/rave/portal/web/api/rpc/PageApi.java
>>>> 1306906
>>>>   /trunk/rave-components/rave-
>>> web/src/main/java/org/apache/rave/portal/web/controller/PageController.
>> j
>>>> ava 1306906
>>>>   /trunk/rave-components/rave-
>>>> core/src/test/java/org/apache/rave/portal/model/PageTest.java 1306906
>>>>   /trunk/rave-components/rave-core/src/main/resources/META-
>>>> INF/persistence.xml 1306906
>>>>   /trunk/rave-components/rave-
>>>> core/src/main/java/org/apache/rave/portal/service/PageService.java
>>>> 1306906
>>>>   /trunk/rave-components/rave-
>>> core/src/main/java/org/apache/rave/portal/service/impl/DefaultPageServic
>> e
>>>> .java 1310534
>>>>   /trunk/rave-components/rave-
>>> core/src/main/java/org/apache/rave/portal/repository/PageRepository.java
>>>> 1308947
>>>>   /trunk/rave-components/rave-
>>> core/src/main/java/org/apache/rave/portal/repository/PageUserRepository
>> .j
>>>> ava PRE-CREATION
>>>>   /trunk/rave-components/rave-
>>> core/src/main/java/org/apache/rave/portal/repository/impl/JpaPageReposi
>> t
>>>> ory.java 1308947
>>>>   /trunk/rave-components/rave-
>>> core/src/main/java/org/apache/rave/portal/repository/impl/JpaPageUserR
>> e
>>>> pository.java PRE-CREATION
>>>>   /trunk/rave-components/rave-
>>> core/src/main/java/org/apache/rave/portal/security/impl/DefaultPagePerm
>> i
>>>> ssionEvaluator.java 1306906
>>>>   /trunk/rave-components/rave-
>>>> core/src/main/java/org/apache/rave/portal/model/PageUser.java PRE-
>>>> CREATION
>>>>   /trunk/rave-components/rave-
>>>> core/src/main/java/org/apache/rave/portal/model/PageStatus.java PRE-
>>>> CREATION
>>>>   /trunk/rave-components/rave-
>>>> core/src/main/java/org/apache/rave/portal/model/Page.java 1306906
>>>>   /trunk/rave-components/rave-
>>>> web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java
>>>> 1306906
>>>>   /trunk/rave-components/rave-
>>> web/src/test/java/org/apache/rave/portal/web/controller/PageControllerT
>> e
>>>> st.java 1325780
>>>>   /trunk/rave-portal-resources/src/main/resources/messages.properties
>>>> 1309125
>>>>   /trunk/rave-portal-resources/src/main/webapp/WEB-
>> INF/db/initial_data.sql
>>>> 1327941
>>>>   /trunk/rave-portal-resources/src/main/webapp/WEB-
>>>> INF/jsp/views/page.jsp 1306906
>>>>   /trunk/rave-portal-resources/src/main/webapp/css/default.css 1306906
>>>>   /trunk/rave-portal-resources/src/main/webapp/script/rave_api.js
>> 1306906
>>>>   /trunk/rave-portal-resources/src/main/webapp/script/rave_layout.js
>>>> 1306906
>>>>   /trunk/rave-portal/src/test/resources/test-data.sql 1306906
>>>>
>>>> Diff: https://reviews.apache.org/r/4843/diff
>>>>
>>>>
>>>> Testing
>>>> -------
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Paul
>>>


Mime
View raw message