rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Sharples <p.sharp...@bolton.ac.uk>
Subject Re: Review Request: RAVE-103. Support shared spaces.
Date Mon, 30 Apr 2012 08:12:36 GMT
On 28/04/2012 12:46, Jasha Joachimsthal wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4843/#review7346
> -----------------------------------------------------------
>
>
> Looks good, apart from a few minor remarks.
>
> What I wondered. If a page is shared by someone else to me, I see a different icon left
from the name. But no indication is shown a page has been shared by me to someone else.

At the moment at least, if your page is shared to someone else the only 
way of seeing this is by selecting the "share page" menu option and 
looking in the list of users to see who has been added.  Perhaps this 
can be improved somehow in the the UI.  I'm not sure what would be a 
good method for showing this.

I'll get onto the updates.

Paul
>
> - Jasha
>
>
> On 2012-04-27 09:42:17, Paul Sharples wrote:
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/4843/
>> -----------------------------------------------------------
>>
>> (Updated 2012-04-27 09:42:17)
>>
>>
>> Review request for rave.
>>
>>
>> Summary
>> -------
>>
>> RAVE-103. support shared spaces.  I've submitted this patch here rather than commit
the code directly, as the changes affect the UI and I wanted a request for comments type approach
first. This is a page sharing patch which allows a user to share his/her page with other rave
users, as well as also allowing the user to revoke page shares. A user who receives a shared
page can opt to confirm the share (meaning the page will always appear in his/her tabbed page
list or decline it (i.e I don't want this shared page).  There's still more to improve on
this, but the basic functionality is there. Note I have removed the render sequencing away
from the page object into the new pageUser object.  This is because with the possibility of
having several users of a page, they all need to have their own page render sequencing. See
RAVE-103.
>>
>>
>> Diffs
>> -----
>>
>>    /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Page.java
1306906
>>    /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/PageStatus.java
PRE-CREATION
>>    /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/PageUser.java
PRE-CREATION
>>    /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/PageRepository.java
1308947
>>    /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/PageUserRepository.java
PRE-CREATION
>>    /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaPageRepository.java
1308947
>>    /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaPageUserRepository.java
PRE-CREATION
>>    /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultPagePermissionEvaluator.java
1306906
>>    /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PageService.java
1306906
>>    /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPageService.java
1310534
>>    /trunk/rave-components/rave-core/src/main/resources/META-INF/persistence.xml 1306906
>>    /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/PageTest.java
1306906
>>    /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/impl/JpaPageRepositoryTest.java
1308947
>>    /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPageServiceTest.java
1327947
>>    /trunk/rave-components/rave-core/src/test/resources/test_data.sql 1308947
>>    /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/PageApi.java
1306906
>>    /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rpc/UserApi.java
PRE-CREATION
>>    /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/PageController.java
1306906
>>    /trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java
1330718
>>    /trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/PageControllerTest.java
1330044
>>    /trunk/rave-portal-resources/src/main/resources/messages.properties 1330724
>>    /trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1327941
>>    /trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1330737
>>    /trunk/rave-portal-resources/src/main/webapp/css/default.css 1330727
>>    /trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1306906
>>    /trunk/rave-portal-resources/src/main/webapp/script/rave_layout.js 1330737
>>    /trunk/rave-portal/src/test/resources/test-data.sql 1306906
>>
>> Diff: https://reviews.apache.org/r/4843/diff
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Paul
>>
>>
>


Mime
View raw message