rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anthony Carlucci" <acarlu...@mitre.org>
Subject Re: Review Request: RAVE-683: Revamp like/dislike display
Date Mon, 09 Jul 2012 14:40:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5617/#review8968
-----------------------------------------------------------


Actually Kristen, let's do this: please create a patch file of only the text changes, and
attach your new image files to the Jira ticket.  I will add them as part of the commit since
SVN seems to have problems with binary diffs

- Anthony Carlucci


On June 27, 2012, 6:27 p.m., Kristen Legacy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5617/
> -----------------------------------------------------------
> 
> (Updated June 27, 2012, 6:27 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle button/count
sizing instead of reconfiguring how button & count function, which has the handy side
effect of preventing the button from being substantially smaller than the like count text
above it.
> 
> https://issues.apache.org/jira/browse/RAVE-683
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1354473 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1354473 
>   trunk/rave-portal-resources/src/main/webapp/static/css/bootstrap/img/glyphicons-halflings-white.png
1354473 
>   trunk/rave-portal-resources/src/main/webapp/static/css/bootstrap/img/glyphicons-halflings.png
1354473 
>   trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1354473 
>   trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1354473 
> 
> Diff: https://reviews.apache.org/r/5617/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kristen Legacy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message