rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristen Legacy" <kristenleg...@gmail.com>
Subject Re: Review Request: RAVE-683: Revamp like/dislike display
Date Mon, 09 Jul 2012 15:00:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5617/
-----------------------------------------------------------

(Updated July 9, 2012, 3 p.m.)


Review request for rave.


Changes
-------

Hey Tony, I removed the image binary from the diff, uploaded the two new images to the Jira
ticket and put the target directory in the comments.


Description
-------

Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle button/count
sizing instead of reconfiguring how button & count function, which has the handy side
effect of preventing the button from being substantially smaller than the like count text
above it.

https://issues.apache.org/jira/browse/RAVE-683


Diffs (updated)
-----

  trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1354473 
  trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1354473 
  trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1354473 
  trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1354473 

Diff: https://reviews.apache.org/r/5617/diff/


Testing
-------


Thanks,

Kristen Legacy


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message