rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Geer" <ch...@cxtsoftware.com>
Subject Re: Review Request: RAVE-717: Screenshot alignment on the widget detail page
Date Tue, 10 Jul 2012 19:04:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5888/#review9032
-----------------------------------------------------------

Ship it!


LGTM - I made one small tweak to disable manually resizing the textareas for comments horizontally
since the screen wouldn't compensate. You can still resize vertically manually.

I will commit

- Chris Geer


On July 10, 2012, 6:12 p.m., Kristen Legacy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5888/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 6:12 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Removed rows on right column content to preserve right margin. Fixed the comment textarea/button
a bit too while I was in there.
> 
> https://issues.apache.org/jira/browse/RAVE-717
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1359691 
>   trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1359691 
> 
> Diff: https://reviews.apache.org/r/5888/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kristen Legacy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message