rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anthony Carlucci" <acarlu...@mitre.org>
Subject Re: Review Request: RAVE-683: Revamp like/dislike display
Date Tue, 10 Jul 2012 20:19:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5617/#review9033
-----------------------------------------------------------



trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/5617/#comment19191>

    remove if no longer needed



trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/5617/#comment19192>

    Please replace hard-coded English language text with fmt:message tags that use the message
bundles



trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/5617/#comment19193>

    remove if no longer needed



trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/5617/#comment19194>

    Please replace hard-coded English language text with fmt:message tags that use the message
bundles



trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/5617/#comment19195>

    Please replace hard-coded English language text with fmt:message tags that use the message
bundles



trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
<https://reviews.apache.org/r/5617/#comment19196>

    Please replace hard-coded English language text with fmt:message tags that use the message
bundles



trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
<https://reviews.apache.org/r/5617/#comment19187>

    remove if no longer needed



trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
<https://reviews.apache.org/r/5617/#comment19186>

    Please replace hard-coded English language text with fmt:message tags that use the message
bundles



trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
<https://reviews.apache.org/r/5617/#comment19188>

    remove if no longer needed



trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
<https://reviews.apache.org/r/5617/#comment19189>

    Please replace hard-coded English language text with fmt:message tags that use the message
bundles



trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
<https://reviews.apache.org/r/5617/#comment19190>

    Please replace hard-coded English language text with fmt:message tags that use the message
bundles


- Anthony Carlucci


On July 9, 2012, 3 p.m., Kristen Legacy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5617/
> -----------------------------------------------------------
> 
> (Updated July 9, 2012, 3 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Restyled buttons & like counts to mimic Stan's proposal. Added JS to handle button/count
sizing instead of reconfiguring how button & count function, which has the handy side
effect of preventing the button from being substantially smaller than the like count text
above it.
> 
> https://issues.apache.org/jira/browse/RAVE-683
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1354473 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1354473 
>   trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1354473 
>   trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1354473 
> 
> Diff: https://reviews.apache.org/r/5617/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kristen Legacy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message