rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anthony Carlucci" <acarlu...@mitre.org>
Subject Re: Review Request: RAVE-624 dynamic debug preference
Date Wed, 11 Jul 2012 17:09:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5844/#review9071
-----------------------------------------------------------


Aaron there appears to be a problem with this patch file, specifically the PortalPreferenceKeys.java
file.  Can you please re-create and upload?

- Anthony Carlucci


On July 9, 2012, 7:48 p.m., Aaron Gooch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5844/
> -----------------------------------------------------------
> 
> (Updated July 9, 2012, 7:48 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Allow dynamic debug mode switching. Preferences will now allow toggle between debug on
and off for container.js. An Event listening interface was created to fire the change and
the DefaultScriptManager implements the interface listening for an event to happen.
> 
> 
> This addresses bug RAVE-624.
>     https://issues.apache.org/jira/browse/RAVE-624
> 
> 
> Diffs
> -----
> 
>   trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeEventListener.java
PRE-CREATION 
>   trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/PortalPreferenceJavascriptDebugModeSaveEvent.java
PRE-CREATION 
>   trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEvent.java
PRE-CREATION 
>   trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventListener.java
PRE-CREATION 
>   trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/events/RaveEventManager.java
PRE-CREATION 
>   trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/PortalPreferenceService.java
1359337 
>   trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceService.java
1359337 
>   trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/PortalPreferenceKeys.java
PRE-CREATION 
>   trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/ScriptManager.java
1359337 
>   trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/renderer/impl/DefaultScriptManager.java
1359337 
>   trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml
1359337 
>   trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/impl/DefaultPortalPreferenceServiceTest.java
1359337 
>   trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/web/renderer/ScriptManagerTest.java
1359337 
>   trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java
1359337 
>   trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java
1359337 
>   trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/WidgetController.java
1359337 
>   trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/PortalPreferenceForm.java
1359337 
>   trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/RegionWidgetTag.java
1359337 
>   trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ScriptTag.java
1359337 
>   trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java
1359337 
>   trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java
1359337 
>   trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/PortalPreferenceControllerTest.java
1359337 
>   trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/admin/WidgetControllerTest.java
1359337 
>   trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/model/PortalPreferenceFormTest.java
1359337 
>   trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/tag/RegionWidgetTagTest.java
1359337 
>   trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/validator/PortalPreferenceFormValidatorTest.java
1359337 
>   trunk/rave-portal-resources/src/main/resources/log4j.xml 1359337 
>   trunk/rave-portal-resources/src/main/webapp/script/rave.js 1340978 
>   trunk/rave-portal/src/test/java/renderer/RenderServiceIntegrationTest.java 1359337

>   trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java
1359337 
>   trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRenderer.java
1359337 
>   trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/test/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRendererTest.java
1359337 
>   trunk/rave-providers/rave-w3c-provider/src/main/java/org/apache/rave/provider/w3c/web/renderer/W3cWidgetRenderer.java
1359337 
> 
> Diff: https://reviews.apache.org/r/5844/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aaron Gooch
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message