rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Geer" <ch...@cxtsoftware.com>
Subject Re: Review Request: Normal users other than admins were not able to comment on widgets.
Date Tue, 17 Jul 2012 21:47:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6016/#review9226
-----------------------------------------------------------

Ship it!


Ship It!

- Chris Geer


On July 17, 2012, 6:05 p.m., Viknes B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6016/
> -----------------------------------------------------------
> 
> (Updated July 17, 2012, 6:05 p.m.)
> 
> 
> Review request for rave and Raminder Singh.
> 
> 
> Description
> -------
> 
> The permission checks were checked for value "create_or_update" but such a switch case
was not present in PermissionEvaluator. Added it and now it works fine.
> 
> 
> This addresses bug Rave-723.
>     https://issues.apache.org/jira/browse/Rave-723
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/security/impl/DefaultWidgetCommentPermissionEvaluator.java
1362302 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/security/impl/DefaultWidgetCommentPermissionEvaluatorTest.java
1362302 
> 
> Diff: https://reviews.apache.org/r/6016/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Viknes B
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message