rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristen Legacy" <kristenleg...@gmail.com>
Subject Re: Review Request: Providing options for relationship status
Date Tue, 24 Jul 2012 17:57:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6095/#review9397
-----------------------------------------------------------

Ship it!


LGTM! 
NOTE: The classes on the label and select will need to be updated should the patch for RAVE-452
be applied.

- Kristen Legacy


On July 23, 2012, 6:35 p.m., Viknes B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6095/
> -----------------------------------------------------------
> 
> (Updated July 23, 2012, 6:35 p.m.)
> 
> 
> Review request for rave and Raminder Singh.
> 
> 
> Description
> -------
> 
> Relationship status is a text box. Added a dropdown with options to choose.
> 
> 
> This addresses bug Rave-727.
>     https://issues.apache.org/jira/browse/Rave-727
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java
1364737 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/resources/messages.properties
1364737 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp
1364737 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/personProfile.jsp
1364737 
> 
> Diff: https://reviews.apache.org/r/6095/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Viknes B
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message