rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anthony Carlucci" <acarlu...@mitre.org>
Subject Re: Review Request: Rave-712: Fixes User (sharer) not seing declined share
Date Fri, 27 Jul 2012 15:24:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6159/#review9535
-----------------------------------------------------------

Ship it!


LGTM!

- Anthony Carlucci


On July 27, 2012, 11:33 a.m., Daniel Gornstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6159/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 11:33 a.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> This fix changes the following behavior after someone declines a shared page:
> 
> 1. If the sharer, were to go share the page again, the person who declined the share
no longer says "Remove", it now says "Add" again.
> 
> 2. If the sharer is not sharing the page to anyone else, the share icon will no longer
be on the tab for that page. 
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1365541 
> 
> Diff: https://reviews.apache.org/r/6159/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Gornstein
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message