rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Gornstein" <dgornst...@mitre.org>
Subject Re: Review Request: Rave 711: Fix Page Rendering before share is accepted
Date Fri, 27 Jul 2012 17:18:01 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 27, 2012, 5:18 p.m.)

Review request for rave.


This is a second fix which does NOT render the content of the page at all instead of hiding
and showing it. 


For this fix I have added code to hide the region with the content of the page until accept
is pressed. After accept is pressed on the callback it reloads the page which shows the content
of the page. If I just did a .show() the resizing of the gadgets was not correct. 

Diffs (updated)

  trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1365541 
  trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1365541 
  trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1365541 

Diff: https://reviews.apache.org/r/6154/diff/



Daniel Gornstein

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message