rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Franklin" <mfrank...@apache.org>
Subject Re: Review Request: RAVE-539: widget store detail display (detail & store pages)
Date Sat, 28 Jul 2012 18:22:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6031/#review9556
-----------------------------------------------------------



trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
<https://reviews.apache.org/r/6031/#comment20417>

    Looks like this should be a choose
    
    <c:choose>
      <c:when test="${condition1}">
        ...
      </c:when>
      <c:when test="${condition2}">
        ...
      </c:when>
      <c:otherwise>
        ...
      </c:otherwise>
    </c:choose>


- Matt Franklin


On July 18, 2012, 4:25 p.m., Kristen Legacy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6031/
> -----------------------------------------------------------
> 
> (Updated July 18, 2012, 4:25 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Improved on style & layout of store and details pages (which now use the same style
rules for the majority of elements).
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/resources/messages.properties 1362964 
>   trunk/rave-portal-resources/src/main/resources/messages_es.properties 1362964 
>   trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1362964 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1362964 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1362964 
>   trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1362964 
>   trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js 1362964 
> 
> Diff: https://reviews.apache.org/r/6031/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kristen Legacy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message