rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Gornstein" <dgornst...@mitre.org>
Subject Re: Review Request: Rave 711: Fix Page Rendering before share is accepted
Date Mon, 30 Jul 2012 13:15:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6154/
-----------------------------------------------------------

(Updated July 30, 2012, 1:15 p.m.)


Review request for rave.


Changes
-------

Regarding Matt's comments, I moved the code back to the script block and preformed the logic
to test if the page status is PENDING there.

This fix makes it so shared pages which are not yet accepted by the user, does not get rendered
in the background.


Description
-------

For this fix I have added code to hide the region with the content of the page until accept
is pressed. After accept is pressed on the callback it reloads the page which shows the content
of the page. If I just did a .show() the resizing of the gadgets was not correct. 


Diffs (updated)
-----

  trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1367061 
  trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1367061 

Diff: https://reviews.apache.org/r/6154/diff/


Testing
-------


Thanks,

Daniel Gornstein


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message