rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Geer" <ch...@cxtsoftware.com>
Subject Re: Review Request: RAVE-532: Bootstrap-enable widget controls (hide gadget menu)
Date Tue, 07 Aug 2012 22:18:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6286/#review9996
-----------------------------------------------------------



trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag
<https://reviews.apache.org/r/6286/#comment21171>

    What is the value of adding the triggerOverlays class? I can't seem to find that being
defined anywhere. Where should I be looking?



trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag
<https://reviews.apache.org/r/6286/#comment21172>

    Was the empty script block intentional?


- Chris Geer


On Aug. 1, 2012, 4:28 p.m., Kristen Legacy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6286/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 4:28 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Adding overlay to capture iframe click events to collapse gadget menu and JS to remove
overlay when clicking anywhere within the parent page. Also sneaking in minor fix to page.jsp
(container-fluid div was closed before elements with row-fluid).
> 
> https://issues.apache.org/jira/browse/RAVE-532
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1367966 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/region_widget.tag 1367966

>   trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less 1367966 
>   trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1367966 
> 
> Diff: https://reviews.apache.org/r/6286/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kristen Legacy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message