rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anthony Carlucci" <acarlu...@mitre.org>
Subject Re: Review Request: RAVE 805 - Catch error when trying to visit a user's page who does not exist
Date Thu, 04 Oct 2012 15:06:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7407/#review12164
-----------------------------------------------------------



trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java
<https://reviews.apache.org/r/7407/#comment25844>

    I think this log statement should remain



trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml
<https://reviews.apache.org/r/7407/#comment25845>

    usernotfound.jsp is missing from the patch


- Anthony Carlucci


On Oct. 3, 2012, 1:54 p.m., Daniel Gornstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7407/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2012, 1:54 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> When visiting a profile page which doesn't exist, show a user not found page instead
of a stack trace, allowing the user to go back to rave easily.
> 
> 
> Diffs
> -----
> 
>   trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java
1393408 
>   trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java
1393408 
>   trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java
1393408 
>   trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java
1393408 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml 1393408 
> 
> Diff: https://reviews.apache.org/r/7407/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Gornstein
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message