-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7407/#review12172
-----------------------------------------------------------
Ship it!
LGTM
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java
<https://reviews.apache.org/r/7407/#comment25852>
minor: since the logic inside this if statement is exactly the same as the PERSON_PROFILE
block above, it's better to make the if condition an "or" check for both patterns. I'll update
with the patch submission.
- Anthony Carlucci
On Oct. 4, 2012, 4:12 p.m., Daniel Gornstein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7407/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2012, 4:12 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> When visiting a profile page which doesn't exist, show a user not found page instead
of a stack trace, allowing the user to go back to rave easily.
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java
1394006
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/util/ControllerUtils.java
1394006
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java
1394006
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java
1394006
> trunk/rave-portal-resources/src/main/resources/messages.properties 1394006
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/usernotfound.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml 1394006
>
> Diff: https://reviews.apache.org/r/7407/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Gornstein
>
>
|