rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Gornstein" <dgornst...@mitre.org>
Subject Re: Review Request: Rave 806 - Friendly error message page when jsDebugMode is off
Date Fri, 05 Oct 2012 14:40:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7408/
-----------------------------------------------------------

(Updated Oct. 5, 2012, 2:40 p.m.)


Review request for rave.


Changes
-------

A new patch which allows setting a preference to show or hide the technical details (stack
trace) on the error page. 


Description
-------

If jsDebugMode is on show the stack trace error as rave currently works. 

If jsDebugMode is off show a friendly error message page


Diffs (updated)
-----

  trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java
1394457 
  trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/PortalPreferenceForm.java
1394457 
  trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ShowStackTraceTag.java
PRE-CREATION 
  trunk/rave-components/rave-web/src/main/resources/META-INF/rave.tld 1394457 
  trunk/rave-portal-resources/src/main/resources/messages.properties 1394457 
  trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1394457 
  trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/preferencedetail.jsp
1394457 
  trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/error.jsp 1394457 

Diff: https://reviews.apache.org/r/7408/diff/


Testing
-------


Thanks,

Daniel Gornstein


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message