rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jasha Joachimsthal <ja...@apache.org>
Subject Re: Review Request: RAVE-539: widget store detail display (detail & store pages)
Date Fri, 05 Oct 2012 08:53:03 GMT
I noticed similar pieces of jsp in the store, w3c store and marketplace
when fixing RAVE-804.. Time for a JSP tag?

On 5 October 2012 09:24, Scott Wilson <scott.bradley.wilson@gmail.com>wrote:

> Hi Kristen,
>
> addwidget_marketplace.jsp is also based on store.jsp so may be worth also
> bringing in line with the style changes.
>
> S
>
> On 4 Oct 2012, at 20:23, Kristen Legacy wrote:
>
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/6031/
> > -----------------------------------------------------------
> >
> > (Updated Oct. 4, 2012, 7:23 p.m.)
> >
> >
> > Review request for rave.
> >
> >
> > Changes
> > -------
> >
> > Trigger happy today. Removed " in choose.
> >
> >
> > Description
> > -------
> >
> > Improved on style & layout of store and details pages (which now use the
> same style rules for the majority of elements).
> >
> >
> > Diffs (updated)
> > -----
> >
> >  trunk/rave-portal-resources/src/main/resources/messages.properties
> 1394204
> >  trunk/rave-portal-resources/src/main/resources/messages_es.properties
> 1394204
> >  trunk/rave-portal-resources/src/main/resources/messages_nl.properties
> 1394204
> >  trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp
> 1394204
> >
>  trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp
> 1394204
> >  trunk/rave-portal-resources/src/main/webapp/static/css/rave-css.less
> 1394204
> >  trunk/rave-portal-resources/src/main/webapp/static/script/rave_store.js
> 1394204
> >
> > Diff: https://reviews.apache.org/r/6031/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Kristen Legacy
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message