rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Franklin" <mfrank...@apache.org>
Subject Re: Review Request: Retrieve security tokens for embedded experiences - #RAVE-851
Date Wed, 05 Dec 2012 21:25:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8320/#review14065
-----------------------------------------------------------



trunk/rave-portal-resources/src/main/webapp/static/script/rave_api.js
<https://reviews.apache.org/r/8320/#comment30073>

    Since security token is localized to the opensocial provider, this function needs to be
in that js file.  



trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/controller/SecurityTokenController.java
<https://reviews.apache.org/r/8320/#comment30074>

    You should also check to see if the gadget is published.  If not, we don't want to enable
an embedded experience with it


- Matt Franklin


On Dec. 3, 2012, 8:31 p.m., Robert O'Neill wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8320/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2012, 8:31 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Shindig provides a hook for a container implementation to specify how to render an embedded
experience. The rave implementation of this hook is incomplete. Opening an embedded experience
will fail because of the way that rave handles security token generation. 
> 
> To fix this, I created an endpoint to dynamically generate a security token for a widget
in the widget store. The security token is retrieved from this endpoint and is registered,
along with the gadget metadata, with the rave container from within the createElementForEmbeddedExperience
shindig hook. Embedded experiences should now render properly in rave.
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/dispatcher-servlet.xml 1415331

>   trunk/rave-portal-resources/src/main/webapp/static/script/rave_api.js 1415331 
>   trunk/rave-portal-resources/src/main/webapp/static/script/rave_opensocial.js 1415331

>   trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/controller/SecurityTokenController.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8320/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Robert O'Neill
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message